Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Memory Leak Risk of Cpp Target #4330

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix Memory Leak Risk of Cpp Target #4330

wants to merge 2 commits into from

Conversation

wangtao9
Copy link
Contributor

See #4237 for details:

image

@wangtao9 wangtao9 changed the title fix memory leak risk of cpp target Fix Memory Leak Risk of Cpp Target Jun 25, 2023
@kaby76 kaby76 mentioned this pull request Jun 27, 2023
Merged
@wangtao9
Copy link
Contributor Author

That's it, I've rebased the latest dev branch and all checks passed!

Before this fix, there was a risk of a memory leak when threads exited prematurely, which was also reported by the asan (AddressSanitizer) check. This PR fixes the above problem, you can use this example to verify the effect: https://github.com/wangtao9/antlr4-perfopt-test/tree/sanitizer_check

@mcb5637 mcb5637 mentioned this pull request Dec 11, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wangtao9