Update Simple auth manager to define its UI (login form) using fastapi

[vincbeck]

SimpleAuthManager is a minimalist auth manager in core Airflow. It defines its own login form in order for users to log in. Example below:

Simple auth manager has its UI defined using Flask, you can then use it with Airflow 2 UI. But the goal is to use simple auth manager in Airflow 3. In order to use simple auth manager with Airflow 3 UI, we need to implement its views in the fastapi application. This is the goal of this PR.

After this PR is merged, I'll remove the UI/views definitions of simple auth manager in Flask. We do not need the simple auth manager to be compatible with Airflow 2 UI (although that was necessary for testing it).

As a result of this PR, multiple endpoints are added:

• <env_endpoint>/auth/webapp/login: the login form
• <env_endpoint>/auth/static/assets/index-......js: the JS/React artifact defining the login form
• POST <env_endpoint>/auth/token: to create a JWT token given username and password

(Sorry for the massive PR).

Testing

To test this PR and play around with the simple auth manager login form:

• Set export AIRFLOW__CORE__AUTH_MANAGER="airflow.auth.managers.simple.simple_auth_manager.SimpleAuthManager"
• In airflow/auth/managers/simple/ui/, run npm run build. I need to update the pre-commit script to do that automatically
• Run Airflow and go to /auth/webapp/login

---

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[bbovenzi]

Tested locally. It works!

I'd like us to match the main UI's setup a bit more. Use pnpm instead of npm and I want to see if we can share the same linting/prettier rules.

[bbovenzi]

We'll need to remember to change this whenever we drop the /webapp. Or better, have one source of truth on the UI base route

[vincbeck]

Tested locally. It works!

I'd like us to match the main UI's setup a bit more. Use pnpm instead of npm and I want to see if we can share the same linting/prettier rules.

I agree that would be great. I made multiple tries but could not come up with something working. Typescript could not recognize types defined in the simple auth manager UI directory. We could give it another try later. I dont think this is a must have for now

[pierrejeambrun]

That's a little unclear for me where we're at and what we want to do for auth managers.

For other auth managers, especially FAB one, do we plan to use the flask middleware to be able to render all of those flask views into fastapi ? (avoiding the flask <-> fastapi convertion, I think this is what was suggested by Jed.)

Then we only do this work for the simple auth manager because we do not need backward compat and because it's more convenient to have that in native FastAPI ?

[vincbeck]

That's a little unclear for me where we're at and what we want to do for auth managers.

For other auth managers, especially FAB one, do we plan to use the flask middleware to be able to render all of those flask views into fastapi ? (avoiding the flask <-> fastapi convertion, I think this is what was suggested by Jed.)

Then we only do this work for the simple auth manager because we do not need backward compat and because it's more convenient to have that in native FastAPI ?

Yes to everything :)

Edit: more details. Mainly because it does not make sense to define the UI in Flask in core Airflow while the future of Airflow is clearly fastapi.

[jedcunningham]

tldr core + simple auth manager should not require flask to be installed at all.

That ship has already sailed if you are using the fab auth manager though, so might as well use the middleware and not rewrite stuff.

[vincbeck]

tldr core + simple auth manager should not require flask to be installed at all.

That ship has already sailed if you are using the fab auth manager though, so might as well use the middleware and not rewrite stuff.

Yep, this is what I did in #45765 for FAB :)

[vincbeck]

Any other concerns/questions?

[vincbeck]

Question for the audience :)

I am looking into updating the basic tests to include tests from the simple auth manager UI as part of the tests-ui. Some caching is done that I am not familiar with. Do I need to do the same or just

- run: cd airflow/auth/managers/simple/ui && pnpm install --frozen-lockfile
- run: cd airflow/auth/managers/simple/ui && pnpm test
  env:
    FORCE_COLOR: 2

[pierrejeambrun]

Any other concerns/questions?

No, thanks for answering my questions.

Overall code looks good and I agree with the general approach.

I think Brent is already working on a detailed review and functional testing.

[vincbeck]

Any other concerns/questions?

No, thanks for answering my questions.

Overall code looks good and I agree with the general approach.

I think Brent is already working on a detailed review and functional testing.

Fantastic! Thank you :)

[pierrejeambrun]

Question for the audience :)

I am looking into updating the basic tests to include tests from the simple auth manager UI as part of the tests-ui. Some caching is done that I am not familiar with. Do I need to do the same or just

I am not super familiar with this workflow but by the look of it I would say that caching the node_modules is always helpful. I think we can just follow the same logic and apply that to the airflow/auth/managers/simple/ui/node_modules folder.
(basically duplicating the Restore and Save cache steps before and after the pnpm install)

[pierrejeambrun]

Re-approved a second time by mistake.

[vincbeck]

I dont understand what is going on ... The command breeze release-management prepare-airflow-package --package-format wheel fails because the pre-commit Compile ui assets (manual) fails because of sh: 1: vite: not found. See error.

However when I run the script scripts/ci/pre_commit/compile_ui_assets.py locally, it works like a charm. vite is listed in package.json so I really dont understand why it cannot find it