Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve listing of HA and non-HA hosts when ha.tag setting is defined and hosts have multiple tags along with ha tag #10240

Draft
wants to merge 1 commit into
base: 4.19
Choose a base branch
from

Conversation

sureshanaparti
Copy link
Contributor

Description

This PR improves listing of HA and non-HA hosts when ha.tag setting is defined and hosts have multiple tags along with ha tag.

Fixes #10070

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

… and hosts have multiple tags along with ha tag
@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 15.13%. Comparing base (91f1ada) to head (cd2cfa1).
Report is 2 commits behind head on 4.19.

Files with missing lines Patch % Lines
.../src/main/java/com/cloud/host/dao/HostDaoImpl.java 0.00% 40 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.19   #10240   +/-   ##
=========================================
  Coverage     15.13%   15.13%           
- Complexity    11279    11282    +3     
=========================================
  Files          5408     5408           
  Lines        474007   474025   +18     
  Branches      57822    57827    +5     
=========================================
+ Hits          71745    71752    +7     
- Misses       394241   394251   +10     
- Partials       8021     8022    +1     
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.85% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HA Host Tag Behavior Inconsistency with multiple tags
2 participants