Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDFS-17711. Change fsimage loading progress percentage discontinuous to continuous #7299

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Last-remote11
Copy link
Contributor

@Last-remote11 Last-remote11 commented Jan 19, 2025

Description of PR

When the name node is restarted with dfs.image.parallel.load enabled, the completion percentage(at namenode web) is reflacted after each thread finished after fsimage loading.
For example, if dfs.image.parallel.target.sections=12(default), the completion percentage increases by 0% -> 8.3% (1/12) -> 16.6% (2/12) ->.... -> 100%.
This is because each thread uses a separate counter.
According docs of org.apache.hadoop.hdfs.server.namenode.startupprogress.getCounter, the counter guarantees thread-safe, so it seems that each fimage loading thread can use the same counter.

How was this patch tested?

run hadoop unit test and tested my test hadoop cluster (version 3.4.0)

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@Last-remote11 Last-remote11 changed the title [HADOOP-17711] Change fsimage loading progress percentage discontinuous to continuous HADOOP-17711 Change fsimage loading progress percentage discontinuous to continuous Jan 19, 2025
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 34m 54s trunk passed
+1 💚 compile 1m 20s trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 compile 1m 9s trunk passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 checkstyle 1m 10s trunk passed
+1 💚 mvnsite 1m 20s trunk passed
+1 💚 javadoc 1m 10s trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 1m 37s trunk passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 spotbugs 3m 7s trunk passed
+1 💚 shadedclient 35m 36s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 4s the patch passed
+1 💚 compile 1m 10s the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 javac 1m 10s the patch passed
+1 💚 compile 1m 0s the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 javac 1m 0s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 54s the patch passed
+1 💚 mvnsite 1m 9s the patch passed
+1 💚 javadoc 0m 56s the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 1m 31s the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
+1 💚 spotbugs 3m 5s the patch passed
+1 💚 shadedclient 35m 43s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 244m 34s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 47s The patch does not generate ASF License warnings.
372m 9s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7299/1/artifact/out/Dockerfile
GITHUB PR #7299
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux c26f47633c38 5.15.0-125-generic #135-Ubuntu SMP Fri Sep 27 13:53:58 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 9c9d747
Default Java Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-gaus1-0ubuntu220.04-ga
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7299/1/testReport/
Max. process+thread count 3461 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7299/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Last-remote11 Last-remote11 changed the title HADOOP-17711 Change fsimage loading progress percentage discontinuous to continuous HDFS-17711 Change fsimage loading progress percentage discontinuous to continuous Jan 19, 2025
@Last-remote11 Last-remote11 changed the title HDFS-17711 Change fsimage loading progress percentage discontinuous to continuous HDFS-17711. Change fsimage loading progress percentage discontinuous to continuous Jan 20, 2025
@Last-remote11 Last-remote11 reopened this Jan 20, 2025
@Last-remote11
Copy link
Contributor Author

Closed and reopened PR due to not linked jira issue properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants