HADOOP-19393. ABFS: Returning FileAlreadyExists Exception for UnauthorizedBlobOverwrite Rename Errors #7312
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manika137
changed the title
snvijaya
suggested changes
Jan 22, 2025
| @@ -613,6 +615,11 @@ public AbfsClientRenameResult renamePath( | |||
| throw e; | |||
| } | |||
|
|
|||
| if(op.getResult().getStorageErrorCode() | |||
| .equals(UNAUTHORIZED_BLOB_OVERWRITE.getErrorCode())){ | |||
| throw new FileAlreadyExistsException("File already exists." ); | |||
There was a problem hiding this comment.
The error string should be "File already exists or request not authorized for blob overrides", as this can happen when destination already exists or if SAS is missing "m".
There was a problem hiding this comment.
Makes sense. Taken.
|
💔 -1 overall
This message was automatically generated. |
|
Aggregated Test Results ============================================================
|
manika137
changed the title
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: https://issues.apache.org/jira/browse/HADOOP-19357
ABFS driver adheres to Hadoop's expectations which does not allow rename blob overwrites. Recently we came across the case where UnauthorizedBlobOverwrite error (HTTP 403- Access Denied Exception) is thrown for rename overwrites (with SAS authentication).
Remapping this error to FileAlreadyExists exception for better understanding.
Adding the test results in comments below.
The one test failure present is intermittent and has been brought up here: https://issues.apache.org/jira/browse/HADOOP-19213