IGNITE-23079 Make Raft storages destruction durable #4987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phillippko
force-pushed
the
ignite-23079
branch
from
dfc7dd9 to
91a601e
Compare
rpuch
reviewed
Dec 30, 2024
There was a problem hiding this comment.
This is a nice first attempt to approach the issue, but it seems to be more complicated than I thought before.
- It would be much better to use a single intent per group, not 2 per group
- Log storage factories should not be aware about destroying something on start (at least, at seems that we could avoid this). Current approach duplicates this logic in the log storage factories
How about trying to pull the knowledge about 'to which log storage factory to route the destruction request on start' higher (to raft server, for example?). We could introduce GroupStoragesDestructionIntent with one method like toIntentIdBytes(). For CMG and MS there would be one implementation (a class with just groupId in it); for partition it would be another implementation (with groupId and isVolatile flag in it). We would then register resolvers with raft server; the resolvers would resolve intent ID bytes to GroupStorageDestructionIntents and to the corresponding destroyers. Raft server would just iterate the destruction event storage, obtain destroyers and call them.
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java
Outdated
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java
Outdated
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/ignite/raft/jraft/storage/impl/VaultDestroyStorageIntentStorage.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/ignite/raft/jraft/storage/impl/VaultDestroyStorageIntentStorage.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/ignite/raft/jraft/storage/impl/VaultDestroyStorageIntentStorage.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/ignite/raft/jraft/storage/impl/VaultDestroyStorageIntentStorage.java
Outdated
Show resolved
Hide resolved
modules/vault/src/main/java/org/apache/ignite/internal/vault/VaultManager.java
Show resolved
Hide resolved
rpuch
reviewed
Jan 17, 2025
...t/src/main/java/org/apache/ignite/internal/raft/storage/GroupStoragesDestructionIntents.java
Show resolved
Hide resolved
...t/src/main/java/org/apache/ignite/internal/raft/storage/GroupStoragesDestructionIntents.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/apache/ignite/internal/raft/storage/GroupStoragesDestructionIntents.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/apache/ignite/internal/raft/storage/GroupStoragesDestructionIntents.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/ignite/internal/raft/storage/impl/VaultGroupStoragesDestructionIntents.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/ignite/internal/raft/storage/impl/VaultGroupStoragesDestructionIntents.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/ignite/internal/raft/storage/impl/VaultGroupStoragesDestructionIntents.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/ignite/internal/raft/storage/impl/VaultGroupStoragesDestructionIntents.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/ignite/internal/raft/storage/impl/VaultGroupStoragesDestructionIntents.java
Outdated
Show resolved
Hide resolved
# Conflicts: # modules/raft/build.gradle
rpuch
reviewed
Jan 22, 2025
modules/core/src/main/java/org/apache/ignite/internal/replicator/PartitionGroupId.java
Outdated
Show resolved
Hide resolved
...rc/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java
Outdated
Show resolved
Hide resolved
modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/ItJraftDestructorTest.java
Outdated
Show resolved
Hide resolved
modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/ItJraftDestructorTest.java
Outdated
Show resolved
Hide resolved
modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/JraftAbstractTest.java
Outdated
Show resolved
Hide resolved
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java
Outdated
Show resolved
Hide resolved
...s/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/DestroyStorageContext.java
Outdated
Show resolved
Hide resolved
...es/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/DestroyStorageIntent.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/ignite/internal/raft/storage/impl/VaultGroupStoragesDestructionIntents.java
Outdated
Show resolved
Hide resolved
| @@ -1186,6 +1200,26 @@ public class IgniteImpl implements Ignite { | |||
| publicCatalog = new PublicApiThreadingIgniteCatalog(new IgniteCatalogSqlImpl(sql, distributedTblMgr), asyncContinuationExecutor); | |||
| } | |||
|
|
|||
| private GroupStoragesContextResolver groupStoragesContextResolver() { | |||
There was a problem hiding this comment.
Suggested change
| private GroupStoragesContextResolver groupStoragesContextResolver() { | |
| private GroupStoragesContextResolver createGroupStoragesContextResolver() { |
rpuch
approved these changes
Jan 22, 2025
|
|
||
| doThrow(LogStorageException.class).doCallRealMethod().when(logStorageFactory).destroyLogStorage(anyString()); | ||
| // New log storage factory was created after restart. | ||
| verify(logStorageFactories.get(SERVER_INDEX), times(0)).destroyLogStorage(anyString()); |
There was a problem hiding this comment.
There is never() that can be used instead of times(0). Up to you
|
Oops, one thing that I forgot: please add tests for serializer (including a test for backward compatibility) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-23079