Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo fix for apidoc #8148

Merged
merged 1 commit into from
Jan 14, 2025
Merged

typo fix for apidoc #8148

merged 1 commit into from
Jan 14, 2025

Conversation

ebarboni
Copy link
Contributor

add missing .html extension for apidoc to pass

@ebarboni ebarboni added the JavaDoc [ci] enable java/javadoc tests and build-javadoc target label Jan 13, 2025
@mbien mbien added this to the NB25 milestone Jan 13, 2025
@matthiasblaesing
Copy link
Contributor

add missing .html extension for apidoc to pass

What does not pass?

@mbien
Copy link
Member

mbien commented Jan 13, 2025

@matthiasblaesing the broken links detector on jenkins:

There were broken links
/home/jenkins/jenkins-agent/workspace/Netbeans_netbeans-TLP_master/nbbuild/build/javadoc/org-netbeans-modules-projectapi/apichanges.html:559:36: Broken link: file:/home/jenkins/jenkins-agent/workspace/Netbeans_netbeans-TLP_master/nbbuild/build/javadoc/org-netbeans-modules-projectapi/org/netbeans/spi/project/NestedClass
/home/jenkins/jenkins-agent/workspace/Netbeans_netbeans-TLP_master/nbbuild/build/javadoc/org-netbeans-modules-projectapi/overview-summary.html:150:36: broken link (already reported): file:/home/jenkins/jenkins-agent/workspace/Netbeans_netbeans-TLP_master/nbbuild/build/javadoc/org-netbeans-modules-projectapi/org/netbeans/spi/project/NestedClass

https://ci-builds.apache.org/job/Netbeans/job/netbeans-TLP/job/master/438/testReport/org.netbeans.nbbuild/CheckLinks/testBrokenLinks/

matthiasblaesing
matthiasblaesing approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks trivially correct to me.

@ebarboni ebarboni merged commit 6869ba2 into master Jan 14, 2025
31 checks passed
@ebarboni ebarboni deleted the apidocfixfornb25 branch January 16, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees
No one assigned
Labels
JavaDoc [ci] enable java/javadoc tests and build-javadoc target
Projects
None yet
Milestone
NB25
Development

Successfully merging this pull request may close these issues.
3 participants
@ebarboni @matthiasblaesing @mbien