Translate Diagnostic.Kind.NOTE to Security.HINT not WARNING

[jglick]

Ever since jenkinsci/stapler#575 I have been bothered by the NetBeans editor showing gratuitous yellow warning lines for a variety of annotation processor notes that are not in fact warnings. For example https://github.com/jenkinsci/workflow-job-plugin/blob/5b18defc07f27c7bde3521e04b7bab66398a89d3/src/main/java/org/jenkinsci/plugins/workflow/job/properties/DisableConcurrentBuildsJobProperty.java#L49-L50 displays warning just because the processor noted that it was generating a file in response to an annotation. Downgrading the “severity” to a “hint” still shows an icon in the gutter, which is OK, and still shows a “warning” in the Action Items window, which is less OK, but at least the editor does not make it look like I did something wrong.

Before:

After:

By the way VS Code using the oracle.oracle-java extension (23.0.1) also suffers from this:

[jglick]

(As an aside, https://github.com/jenkinsci/workflow-job-plugin/blob/5b18defc07f27c7bde3521e04b7bab66398a89d3/src/main/java/org/jenkinsci/plugins/workflow/job/properties/DisableConcurrentBuildsJobProperty.java#L62 shows no warning inside the IDE even though https://github.com/jglick/sezpoz/blob/9aad5b93fee760b658f423eae611b04b874b75e4/sezpoz/src/main/java/net/java/sezpoz/impl/Indexer.java#L161-L163 prints a diagnostic NOTE for it, I suppose because currently there is no associated Element location.)

[lahodaj]

This looks reasonable to me. We could also consider dropping NOTEs completely, as they typically do not carry much useful information.

Yes, I believe Diagnostics that are not associated with a file are ignored here.

[jglick]

CI is reporting a failure in

netbeans/java/java.hints/test/unit/src/org/netbeans/modules/java/hints/FieldForUnusedParamTest.java

Lines 109 to 124 in c7949a1

	public void testMultipleCtors() throws Exception {
	performFixTest("test/Test.java",
	"package test;\n" +
	"public class Test {\n" +
	" private int a;\n" +
	" private int c;\n" +
	" public Test() {}\n" +
	" public Test(int a, int |b, int c) {\n" +
	" this.a = a;\n" +
	" this.c = c;\n" +
	" }\n" +
	"}\n",
	"5:28-5:28:hint:Unused Parameter",
	"FixImpl:false",
	"package test; public class Test { private int a; private int b; private int c; public Test() {} public Test(int a, int b, int c) { this.a = a; this.b = b; this.c = c; } } ");
	}

which I do not get locally.

[matthiasblaesing]

That test is known to be flaky. I restarted the test run for that test group.

[mbien]

CI is reporting a failure in

I extracted it into a separate issue #8195 since this has potential to be a real bug, test stability meta issue is #8183