Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHPStan error identifiers #8170

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

KacerCZ
Copy link
Contributor

@KacerCZ KacerCZ commented Jan 18, 2025

PHPStan since version 1.11 uses identifiers for errors.
Error identifiers are read and displayed with this change.

Reference: https://phpstan.org/blog/phpstan-1-11-errors-identifiers-phpstan-pro-reboot#error-identifiers

Before:
image

After:
image

PHPStan since version 1.11 uses identifiers for errors.
Error identifers are read and displayed with this change.
Reference: https://phpstan.org/blog/phpstan-1-11-errors-identifiers-phpstan-pro-reboot#error-identifiers
@KacerCZ KacerCZ added the PHP [ci] enable extra PHP tests (php/php.editor) label Jan 18, 2025
@KacerCZ KacerCZ added this to the NB25 milestone Jan 18, 2025
@KacerCZ KacerCZ requested a review from junichi11 January 18, 2025 10:51
Copy link
Member

@junichi11 junichi11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for your work!
Can you attach a screenshot?

@KacerCZ
Copy link
Contributor Author

KacerCZ commented Jan 19, 2025

Thanks for the review.

@junichi11
Copy link
Member

junichi11 commented Jan 19, 2025

Thanks! Please attach it to the above description because someone may look at this change after NB25 is released. (Also before one if possible.)

@KacerCZ KacerCZ merged commit 5241929 into apache:master Jan 19, 2025
32 checks passed
@KacerCZ
Copy link
Contributor Author

KacerCZ commented Jan 19, 2025

Changed screenshot and merged.
Thank you.

@KacerCZ KacerCZ deleted the phpstan-error-identifiers branch January 19, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants