fix: set target socket max listeners to infinity #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-platform
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
jancurn
reviewed
Jan 22, 2025
| @@ -88,6 +88,9 @@ export const chain = ( | |||
| client.on('connect', (response, targetSocket, clientHead) => { | |||
| countTargetBytes(sourceSocket, targetSocket); | |||
|
|
|||
| // There may be many .on('close') listeners, so we need to increase the limit. | |||
| targetSocket.setMaxListeners(Infinity); | |||
There was a problem hiding this comment.
Isn't this risky? The warning is there to help detect memory leaks, now we turn this off and if proxy starts crashing, we won't even know why. Maybe increase it too like 1000 instead?
fnesveda
requested changes
Jan 22, 2025
Based on what would that solve the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happens that
targetSockethas many.on('close', ...)listeners and we getMaxListenersExceededWarning. I increase the limit to infinity so we don't see such warnings.I'd guess this is due to the fact that some target sockets can be reused/kept alive and therefore they have more on close listeners attached from several source sockets.