Deduplicate error wrappers and error causes #1366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We got a report that an Action View error was reported twice. Once the `ActionView::Template::Error` wrapper and once the error that actually occurred in the view (the error cause, e.g. `NoMethodError`). This was caused by receiving the error cause from the Rails error reporter and the error wrapper in our error middleware. This was detailed in issue appsignal/support#345 and Rails issue rails/rails#53938. (This only happened in production due to a Rails behavior quirk between development and production, addressed in the issue I linked above.) This change will make sure we do not report both errors, but only report the `ActionView::Template::Error`. Closes appsignal/support#345
unflxw
reviewed
Jan 13, 2025
unflxw
approved these changes
Jan 13, 2025
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
luismiramirez
approved these changes
Jan 22, 2025
This is a message from the daily scheduled checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got a report that an Action View error was reported twice. Once the
ActionView::Template::Errorwrapper and once the error that actually occurred in the view (the error cause, e.g.NoMethodError).This was caused by receiving the error cause from the Rails error reporter and the error wrapper in our error middleware. This was detailed in issue https://github.com/appsignal/support/issues/345 and Rails issue rails/rails#53938. (This only happened in production due to a Rails behavior quirk between development and production, addressed in the issue I linked above.)
This change will make sure we do not report both errors, but only report the
ActionView::Template::Error.Closes https://github.com/appsignal/support/issues/345