Fix HTTP.rb when using non-ASCII URIs #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ All good! |
When Appsignal is enabled, it hooks into HTTP request method. It
uses `URI.parse` when uri is a string, but `URI.parse` doesn't
support non-ascii characters:
```ruby
HTTP.get("http://www.example.com/áéíóúãÔù")
```
With Appsignal enabled, the code above raises this error:
```
URI::InvalidURIError:
URI must be ascii only
```
The solution I found was using Addressable::URI.parse since it
handles non-ascii characters.
ps.: Addressable is a HTTP's runtime dependency since 2015
unflxw
force-pushed
the
fix-http-non-ascii-uri
branch
from
b1e6457 to
75592ac
Compare
luismiramirez
approved these changes
Jan 22, 2025
tombruijn
approved these changes
Jan 22, 2025
The `http` gem exposes the `HTTP::URI` module, which on different versions of the gem either subclasses or extends `Addressable::URI`. Use it instead of referring directly to `Addressable::URI`, avoiding explicitly depending on the implementation detail that `HTTP::URI` uses `Addressable::URI` internally. When `HTTP::URI` is not defined (in `http` gem versions before 0.8.0) fall back to using `URI` instead.
unflxw
force-pushed
the
fix-http-non-ascii-uri
branch
from
75592ac to
fce0acd
Compare
unflxw
changed the title
This is a message from the daily scheduled checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1369 (thanks @stephannv!)
Fix HTTP.rb non-ascii URI
When Appsignal is enabled, it hooks into HTTP request method. It
uses
URI.parsewhen uri is a string, butURI.parsedoesn'tsupport non-ascii characters:
With Appsignal enabled, the code above raises this error:
The solution I found was using Addressable::URI.parse since it
handles non-ascii characters.
ps.: Addressable is a HTTP's runtime dependency since 2015
Use HTTP::URI if defined
The
httpgem exposes theHTTP::URImodule, which on differentversions of the gem either subclasses or includes
Addressable::URI.Use it instead of referring directly to
Addressable::URI, avoidingexplicitly depending on the implementation detail that
HTTP::URIuses
Addressable::URIinternally.When
HTTP::URIis not defined (inhttpgem versions before 0.8.0)fall back to using
URIinstead.