Add star rating component #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for streamlit-extras-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @GabrielVidal1, thank you for this contribution! Do you mind pulling from |
| from streamlit.components.v1 import html | ||
|
|
||
|
|
||
| def star_rating(rating: float, color="#FFD700"): |
There was a problem hiding this comment.
color can be type-hinted as str:
Suggested change
| def star_rating(rating: float, color="#FFD700"): | |
| def star_rating(rating: float, color: str = "#FFD700"): |
GabrielVidal1
force-pushed
the
start-component
branch
from
80b97d9 to
7e6b168
Compare
|
I did the fixes and rebased on main! |
|
@GabrielVidal1 sorry I was out for a bit. I didn't catch it last time, but you're missing the from .. import extra
@extra
def star_rating(...):
# original implementation |
arnaudmiribel
requested changes
Oct 21, 2024
GabrielVidal1
force-pushed
the
start-component
branch
from
7e6b168 to
89cadb3
Compare
arnaudmiribel
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple readonly star rating with custom color