Update InternalApiBoundaryTest to skip flagging the use of protected APIs that are in internal package #5774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
force-pushed
the
zoewang/improveTests
branch
from
5fbb39c to
3e55819
Compare
Fred1155
approved these changes
Jan 13, 2025
davidh44
approved these changes
Jan 14, 2025
zoewangg
force-pushed
the
zoewang/improveTests
branch
from
b23f1c6 to
cf6cdb1
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Update
InternalApiBoundaryTestto skip flagging the use of protected APIs that are in internal package because those APIs should already be flagged and given exceptions inPackageContainmentTestMark NullJsonNode as protected API because it's already used in other modules.