Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add notes about instanceStorePolicy that can help prevent deadlock #7566

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

bclodius
Copy link
Contributor

@bclodius bclodius commented Jan 3, 2025

Fixes #7543

Description

How was this change tested?

  • N/A doc update only

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bclodius bclodius requested a review from a team as a code owner January 3, 2025 18:36
@bclodius bclodius requested a review from engedaam January 3, 2025 18:36
Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 338563c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67885c89224a940008c2dc5e
😎 Deploy Preview https://deploy-preview-7566--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bclodius
Copy link
Contributor Author

bclodius commented Jan 3, 2025

image

@engedaam engedaam self-assigned this Jan 14, 2025
@engedaam
Copy link
Contributor

@bclodius Any update here?

@bclodius
Copy link
Contributor Author

@engedaam Thanks for the suggestion I'll take care of this today

@bclodius bclodius requested a review from engedaam January 16, 2025 01:10
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12800041847

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.983%

Totals Coverage Status
Change from base Build 12777192606: 0.0%
Covered Lines: 5775
Relevant Lines: 8887

💛 - Coveralls

@engedaam engedaam merged commit e34bf5a into aws:main Jan 16, 2025
17 checks passed
edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional notes about instanceStorePolicy for EC2 Node Class
3 participants