Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option for extra hourly cost per host #7609

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jasonwbarnett
Copy link

@jasonwbarnett jasonwbarnett commented Jan 19, 2025

Fixes #5163

Description

This feature allows specifying an extra hourly cost per host for thing like Datadog APM agent, etc.

How was this change tested?

  1. Create a nodepool with only xlarge and 2xlarge instance sizes.
  2. Created a test Deployment with 1 pod with 1 cpu/2GB memory requests with 100 replicas.
  3. Modify the nodepool and add all instance sizes.
  4. Modify the karpenter-aws-provider deployment and set EXTRA_HOURLY_COST_PER_HOST to "1.0"

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Other Info

I considered adding the extra hourly cost per host to the static pricing for environments without access to the pricing API. However, this would require passing context into Reset() based on the current implementation, which introduces significant ripple effects across the entire test stack. I’m curious if anyone has alternative ideas or solutions to address this challenge.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jasonwbarnett jasonwbarnett requested a review from a team as a code owner January 19, 2025 20:09
Copy link

netlify bot commented Jan 19, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit ae81123
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/678d5f1aa0ef360008bb7436

@jasonwbarnett jasonwbarnett force-pushed the feat/extra-hourly-cost-per-host branch 2 times, most recently from 2467bed to f53e234 Compare January 19, 2025 20:21
@jasonwbarnett jasonwbarnett force-pushed the feat/extra-hourly-cost-per-host branch from f53e234 to ae81123 Compare January 19, 2025 20:22
@jasonwbarnett
Copy link
Author

I just submitted this PR and wanted to reach out for help and guidance. If I missed anything or there are changes you’d like me to make, please let me know—I’m more than happy to address them promptly. Thanks for taking the time to review this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Pricing Overrides for RIs, Savings Plans, and other strategies
1 participant