Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Core/Scripts) Fixes the misuse of the "Acidic Wound" skill in Phase 2 #21208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EricksOliveira
Copy link
Contributor

Added conditional check in JustEngagedWith to prevent Acidic Wound from being cast during Phase 2.

Changes Proposed:

This PR proposes changes to:

  • [x ] Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • [x ] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • [x ] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • [x ] Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • [x ] This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
  1. Be the target on Gurtogg's Fel Rage

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Added conditional check in JustEngagedWith to prevent Acidic Wound from being cast during Phase 2.
@github-actions github-actions bot added Script file-cpp Used to trigger the matrix build labels Jan 18, 2025
@EricksOliveira EricksOliveira changed the title fiz(Core/Scripts) Fixes the misuse of the "Acidic Wound" skill in Phase 2 fix(Core/Scripts) Fixes the misuse of the "Acidic Wound" skill in Phase 2 Jan 18, 2025
@Nyeriah
Copy link
Member

Nyeriah commented Jan 18, 2025

Were the changes on this PR tested?

@Nyeriah
Copy link
Member

Nyeriah commented Jan 19, 2025

JustEngagedWith() is only called once, when the creature first enters combat. Gurtogg casts the aura (SPELL_ACIDIC_WOUND) on himself on pull, the aura then triggers the application as long as he has the aura. So this PR as it is, cannot address this issue

image

@EricksOliveira
Copy link
Contributor Author

Were the changes on this PR tested?

I apologize. I made a quick update without testing. But I'm working on it. I'll be sending an update today to resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-cpp Used to trigger the matrix build Ready to be Reviewed Script
Projects
None yet
3 participants