feat(Core/World): implement Sun's Reach Reclamation Event and Phasing #21219
+1,378
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
This builds and I included the data from Bench. It can do phase handling, but data is incomplete. Phases activate game_events. Each phase needs to have spawns/gobjects/quests set. When compared to cmangos, handlings looks OK but data is incomplete. Though cmangos isn't working prefectly either, like the anvil progression is missing, but spawns are much better.
As for style, init world states is ugly. Not sure what it does, dialog % when talking to the guy next to the island portal in Shat.
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
Commands:
.worldstate sunsreach phase
print phase info (phase, subphase, counters).worldstate sunsreach phase 1
sets phase to [0-4] setting 4->1 is valid.worldstate sunsreach subphase
print phase info (phase, subphase, counters).worldstate sunsreach subphase 1
Sets subphase mask; e.g., 0x3 sets 0x2 (anvil) and 0x1 (portal). Maybe reversable, didn't work when I tried.worldstate sunsreach counter
print phase info (phase, subphase, counters).worldstate sunsreach counter 999
sets counter, quest completions increase counter, once a value is reached (worldconfig), transitions to next phase/subphaseHow to Test the Changes:
.worldstate sunsreach phase [0-4]
all subphases,
.worldstate sunsreach subphase 15
spawns, weather, music
.worldstate sunsreach phase [0-4]
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.