Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JHy updated DrainageSystem-1-2 #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

larswik
Copy link
Collaborator

@larswik larswik commented Jun 28, 2021

After reviewing the file against the original LandXML, noticed that the sizes of pipes and manholes don’t match. The diameters given in LandXML for Structs and Pipes seem to have been taken as outer dimensions, when they are inner values instead. This doesn’t really matter in unit tests, but for a good example to pass around, I’d like to get it fixed.

Another small issue is the Axis representation, which now follows the pipe centre-lines, but the domain practice (in Finland, anyway) is to follow the invert level for gravity-fed lines (outside-top level for pressure-pipes).

I’ve made the changes in the profile definitions to get the sizes right, and dealt with the Axis-issue by changing the local placements of the pipes to have origin at invert level (each axis polyline starting at 0,0,0), and indicating the used cardinal point by changing the value in IFCMATERIALPROFILESETUSAGE from 5 to 20 (see below), and also giving appropriate offset in IFCCIRCLEHOLLOWPROFILEDEF.Position.

Unit test

Update of file DrainageSystem-1-2.ifc for UT DrainageSystem-1

Covered topics

tick one/many

  • project setup
  • [] georeferencing
  • alignment semantics
  • alignment geometry
  • linear placement
  • project breakdown structure / spatial structure
  • terrain
  • triangulated irregular network
  • open cross profile
  • sectioned surface & solid
  • pavement & course
  • surface feature
  • earthworks
  • geotechnics
  • longitudinal products (barriers, guardrail, ...)
  • interchange
  • structural
  • drainage
  • signage
  • road furniture
  • rail furniture
  • ports & waterways furniture
  • bridge furniture

After reviewing the file against the original LandXML, noticed that the sizes of pipes and manholes don’t match. The diameters given in LandXML for Structs and Pipes seem to have been taken as outer dimensions, when they are inner values instead. This doesn’t really matter in unit tests, but for a good example to pass around, I’d like to get it fixed.

Another small issue is the Axis representation, which now follows the pipe centre-lines, but the domain practice (in Finland, anyway) is to follow the invert level for gravity-fed lines (outside-top level for pressure-pipes).

I’ve made the changes in the profile definitions to get the sizes right, and dealt with the Axis-issue by changing the local placements of the pipes to have origin at invert level (each axis polyline starting at 0,0,0), and indicating the used cardinal point by changing the value in IFCMATERIALPROFILESETUSAGE from 5 to 20 (see below), and also giving appropriate offset in IFCCIRCLEHOLLOWPROFILEDEF.Position.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant