Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reviewing the file against the original LandXML, noticed that the sizes of pipes and manholes don’t match. The diameters given in LandXML for Structs and Pipes seem to have been taken as outer dimensions, when they are inner values instead. This doesn’t really matter in unit tests, but for a good example to pass around, I’d like to get it fixed.
Another small issue is the Axis representation, which now follows the pipe centre-lines, but the domain practice (in Finland, anyway) is to follow the invert level for gravity-fed lines (outside-top level for pressure-pipes).
I’ve made the changes in the profile definitions to get the sizes right, and dealt with the Axis-issue by changing the local placements of the pipes to have origin at invert level (each axis polyline starting at 0,0,0), and indicating the used cardinal point by changing the value in IFCMATERIALPROFILESETUSAGE from 5 to 20 (see below), and also giving appropriate offset in IFCCIRCLEHOLLOWPROFILEDEF.Position.
Unit test
Update of file DrainageSystem-1-2.ifc for UT DrainageSystem-1
Covered topics
tick one/many