Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(btccheckpoint): remove unnecessary index boundary check #367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(btccheckpoint): remove unnecessary index boundary check #367

wants to merge 1 commit into from

Conversation

lukema95
Copy link

Remove unnecessary index boundary check in checkpoint data processing since:

  • Loop index i is always non-negative in Go
  • NumberOfParts is fixed at 2, so i will never exceed math.MaxUint8

@lukema95 lukema95 requested a review from a team as a code owner December 22, 2024 13:00
@lukema95 lukema95 requested review from KonradStaniec and samricotta and removed request for a team December 22, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonradStaniec KonradStaniec Awaiting requested review from KonradStaniec KonradStaniec was automatically assigned from babylonlabs-io/core-dev

@samricotta samricotta Awaiting requested review from samricotta samricotta was automatically assigned from babylonlabs-io/core-dev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukema95