Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usePasswordGrantOnRefreshFailure config for password grant type token refresh failures #1333

Conversation

lakpahana
Copy link

Purpose

This PR introduces the usePasswordGrantOnRefreshFailure configuration, allowing the token refresh flow to fallback to the password grant type if the refresh token flow fails. This enhancement improves flexibility in handling token refresh scenarios while ensuring clear and maintainable logic.

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2024

CLA assistant check
All committers have signed the CLA.

@MohamedSabthar
Copy link
Member

Hi @lakpahana,

Using the Password Grant Type when a refresh token fails is not considered a standard practice in OAuth2. If this behavior is required for a specific reason, it should be implemented in the user code rather than being handled within the library.

@lakpahana
Copy link
Author

Hi @lakpahana,

Using the Password Grant Type when a refresh token fails is not considered a standard practice in OAuth2. If this behavior is required for a specific reason, it should be implemented in the user code rather than being handled within the library.

Thanks for the feedback. I will implement it in the application itself.

@lakpahana lakpahana closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants