Minor changes for readability. #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for catanatron-staging pending review.Visit the deploys page to approve it
|
tonypr
force-pushed
the
minor_changes_3
branch
from
9b7f7fa to
b8af070
Compare
|
Cool! Thanks for the contribution. I fixed the CI issues in master, so updating this branch with master should fix build! 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor style/readability improvements:
expandable_nodescomputation. Nodes in the connected component should only be from that color, so we can remove the existing color check.is_enemy_roadby not adding the extrais not Nonecheck as it's not needed. It shouldn't be needed foris_enemy_nodeeither.. but that seemed to fail for some reason I didn't get into.longest_acyclic_pathmethod to prefer.appendin the DFS search for performance as .insert(0) shifts the whole list. Would have to use a queue otherwise but it's not necessary.longest_acyclic_pathmethod by using helper methods for friendly/enemy roads/nodes.Tested with:
coverage run --source=catanatron -m pytest tests/