Clean up CMake build #1964
Merged
Clean up CMake build #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…directory on each target
This silences most warnings about overriding /W3 with /w
Generator expressions were used to prevent the addition of /MD and /Zi if the CMake version is new enough to have specific MSVC variables for controlling those flags
MSVC flag is not needed and the minimum CMake version is higher now
It's not a valid flag for static linking
|
Oooh, nice! I am not a cmake guru, but @jlblancoc is :-) and he might also have visibility on effect on ROS (if any). I requested a review from him to look over this. The CI will also tell us a lot. |
|
PS, @Gold856, not a deal-breaker, but I am more comfortable with contributors that have their name and affiliation listed. We can then also properly acknowledge you in a next release. |
jlblancoc
reviewed
Jan 8, 2025
|
@dellaert ROS builds shouldn't be affected (but I'll keep an eye on the build farm). |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the use of more standard CMake variables for controlling things like PIC, output directories, and MSVC flags, and also removes redundancies like empty prefixes on Windows. This also sets all CMake policies up to 3.29 to NEW, which allows certain MSVC flags to be controlled by variables instead, and removes /W3 from the default set of flags, which reduces the number of warnings of compile flags being overriden to about 2.