Fix/1452 #1977
Fix/1452 #1977
Conversation
| */ | ||
| int main() { | ||
| // Path to the test data file | ||
| ifstream infile("IncrementalFixedLagSmootherTestData.txt"); |
There was a problem hiding this comment.
Could you load the file as in the test I provided in this branch?
| saveG2oGraph(smoother.getFactors(), currentEstimate, path + "isam", lineCount); | ||
| infile.close(); | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
Add a new line at end of file, please
|
You’re merging this into the branch I created, which added this as a unit test. I don’t think we need both, so could you also delete the test in this PR? Also look at how I load the file, and perhaps how I now use |
…eading files and adding factors.
Sorry, I just noticed that you have already provided the data file |
Ping on this comment :-) |
|
Hi @JokerJohn - I actually liked your example - I was asking to remove the test :-) |
Sorry，I saw the unit test code for issue 1452, which has already incorporated the example code, so I closed this PR. If there's a need to change it into an example case, I can reopen this PR. |
|
Excellent, but could you then remove the (slow and redundant) unit test that basically does the same? Your example shows (a) it works, (b) a useful example. |
done. |
Add a minimal test case of
IncrementalFixedLagSmootheringtsam/gtsam_unstable/examplesfolder using real-world data to showcase how settingfindUnusedFactorSlots = trueaddresses the issue #1452 in GTSAM.