Fix GCC 13 warnings #1978
Merged
Fix GCC 13 warnings #1978
+17
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jmackay2
reviewed
Jan 18, 2025
| @@ -9,6 +9,10 @@ | |||
| #include <gtsam/geometry/FundamentalMatrix.h> | |||
| #include <gtsam/geometry/Point2.h> | |||
|
|
|||
| #ifdef __GNUC__ | |||
| #pragma GCC diagnostic ignored "-Wmaybe-uninitialized" | |||
There was a problem hiding this comment.
This is probably the simplest solution for now, but it is nice that in Eigen 3.4 the SVD implementations have an info() method that can be used to check it and fix the uninitialized warning.
Eigen::JacobiSVD<Matrix3> svd(F, Eigen::ComputeFullU | Eigen::ComputeFullV);
if (svd.info() != Eigen::ComputationInfo::Success) {
throw std::runtime_error("FundamentalMatrix::FundamentalMatrix unsuccessful svd computation");
}
|
Yeah my take is that these warnings seem spurious (in most cases -- at least those we found in this MR, with the exception of examples/TriangulationLOSTExample.cpp), and we should build with |
Globally? That seems too dangerous. I’m already queasy with a file-level exception :-) After you remove the workflow edits, however, I’m ok with the PR as is. We should then open an issue to look more closely as to what’s happening. |
|
Your proposed edit is way better - in that it kills the pragmas. |
|
Getting this set of errors when building The stringop-overread warning is new. I really do think we should use |
Gold856
force-pushed
the
fix-warnings
branch
2 times, most recently
from
4591e01 to
1f89665
Compare
|
Quick question: are you only seeing this on GCC? |
|
I haven’t tried Clang, only GCC. |
dellaert
reviewed
Jan 21, 2025
|
I added more pragmas to some of the tests so they don't fail when building. I set them up to still print out warnings though so we don't forget. |
|
OK. ready to merge? |
|
Building all the tests and examples without Boost works on my machine, so I'm ready when you are. |
|
Merged! Many thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1967 and fixes #1981.