Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change logo to support dynamic year #120

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Change logo to support dynamic year #120

wants to merge 12 commits into from

Conversation

idatorgersen
Copy link
Contributor

Description

Logo supports dynamic year, needs error handling when we get data from backend

Testing Done

Type of change

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to break)
  • Documentation update required for this change

Checklist:

  • My code adheres to the style guidelines of this project
  • I have performed a self-review of my code
  • I have added comments to my code, especially in complex areas
  • I have updated the documentation accordingly
  • My changes do not introduce any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my feature
  • Both new and existing unit tests pass locally with my changes
  • I have considered and addressed any potential security implications

idatorgersen and others added 12 commits January 7, 2025 15:30
@idatorgersen
Dynamic logo year, added notfound-page
b319f0a
@tormodAase @idatorgersen
fix: menu navigation (#112)
58f65f7 
* fix: header tabs should now work correctly

* fix: mobile version should also work properly

* fix issues with build
@idatorgersen
Adjustments to match Bouvet design manual, added prettier
e7faf60
@idatorgersen
Support reversed x-values in dotplot chart
e8ecd8f
@idatorgersen
Added description labels for markers in dotplotchart
0f42d74
@asleboon @idatorgersen
feat: add manual trigger
7972d40
@Jone-Torgersen @idatorgersen
fix: unify chart counter position for all charts
6d9c7ee 
- Added flex-1 container around children in answerContiner
- Removed absolute positioning on chart counter in favor of margin top auto to ensure
- Added flex and updated chart-container style to allow a uniform positioning for the chartcounter
@idatorgersen
Added description labels for markers in dotplotchart
d5e8a64
@idatorgersen
wip, failed merge
390a4ea
@idatorgersen
wip, failed merge
da61d82
@tormodAase @idatorgersen
chore: remove yarn and patch vulnerabilities (#117)
6ca89f9 
* chore: delete unnecessary lockfiles

* chore: update readme to only show npm command

* chore: patch vulnerabilities

* chore: add `ts-node` to make sure `npm run test` doesn't fail

* chore: remove yarn from pullRequest GH action
@idatorgersen
Bug from merge
1b0d645
@idatorgersen idatorgersen linked an issue Jan 9, 2025 that may be closed by this pull request
Change logo to support dynamic year #92
Open
Trulsmatias
Trulsmatias approved these changes Jan 17, 2025
View reviewed changes
Copy link

@Trulsmatias Trulsmatias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trulsmatias Trulsmatias Trulsmatias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change logo to support dynamic year
5 participants
@idatorgersen @Trulsmatias @tormodAase @asleboon @Jone-Torgersen