Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vnet and private endpoint to sql database #139

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

asleboon
Copy link
Contributor

Description

Testing Done

Type of change

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to break)
  • Documentation update required for this change

Checklist:

  • My code adheres to the style guidelines of this project
  • I have performed a self-review of my code
  • I have added comments to my code, especially in complex areas
  • I have updated the documentation accordingly
  • My changes do not introduce any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my feature
  • Both new and existing unit tests pass locally with my changes
  • I have considered and addressed any potential security implications

@asleboon asleboon force-pushed the feature/sql-server-managed-identity branch from 2cc3796 to 2312b65 Compare January 23, 2025 12:38
@asleboon asleboon changed the title feat: add db access to managed identity feat: add vnet and private endpoint to sql database Jan 24, 2025
@asleboon asleboon force-pushed the feature/sql-server-managed-identity branch from 3e42ff8 to 2a28989 Compare January 24, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant