Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup gnomAD toolbox repository #1

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Setup gnomAD toolbox repository #1

merged 8 commits into from
Jul 24, 2024

Conversation

jkgoodrich
Copy link
Contributor

ch-kr
ch-kr reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much for setting this up and adding supports for tests! I have a few minor comments

.gitignore Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
requirements-dev.in Outdated Show resolved Hide resolved
.pylintrc Show resolved Hide resolved
.pylintrc Outdated Show resolved Hide resolved
gnomad_toolbox/__init__.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
setup.py Show resolved Hide resolved
@jkgoodrich jkgoodrich requested a review from ch-kr July 24, 2024 16:51
ch-kr
ch-kr approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkgoodrich jkgoodrich merged commit 8bde073 into main Jul 24, 2024
2 checks passed
@jkgoodrich jkgoodrich deleted the jg/setup branch July 24, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch-kr ch-kr ch-kr approved these changes

@mike-w-wilson mike-w-wilson Awaiting requested review from mike-w-wilson

Assignees

@mike-w-wilson mike-w-wilson

@ch-kr ch-kr

@jkgoodrich jkgoodrich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkgoodrich @ch-kr @mike-w-wilson