Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use some interval functions added to gnomad_methods #14

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

jkgoodrich
Copy link
Contributor

@jkgoodrich jkgoodrich commented Jan 10, 2025

We can switch to using the gnomAD browser gene HT if we want, but I think this function makes it very clear what the actual filters being applied are

gnomad_toolbox/filtering/variant.py Outdated Show resolved Hide resolved
gnomad_toolbox/filtering/variant.py Outdated Show resolved Hide resolved
gnomad_toolbox/filtering/variant.py Show resolved Hide resolved
@jkgoodrich jkgoodrich requested a review from KoalaQin January 14, 2025 14:11
gnomad_toolbox/filtering/variant.py Outdated Show resolved Hide resolved
gnomad_toolbox/filtering/variant.py Outdated Show resolved Hide resolved
@jkgoodrich jkgoodrich requested a review from KoalaQin January 15, 2025 17:21
Copy link
Contributor

@KoalaQin KoalaQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KoalaQin
Copy link
Contributor

You can merge this, and once other PR is in, I can merge the changes in my PR.

@jkgoodrich jkgoodrich merged commit 93414d4 into qh/filter_by_gene_symbol Jan 15, 2025
2 checks passed
@jkgoodrich jkgoodrich deleted the jg/filter_by_gene_symbol branch January 15, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants