Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to support Go 1.23 #139

Merged
merged 6 commits into from
Aug 16, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions .github/workflows/buf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,15 @@ on:
pull_request:
paths:
- 'proto/**'
- 'buf.*'
push:
paths:
- 'proto/**'
- 'buf.*'
delete:
paths:
- 'proto/**'
- 'buf.*'

env:
BUF_TOKEN: ${{ secrets.BUF_TOKEN }}
Expand All @@ -22,17 +25,15 @@ jobs:
- name: Checkout code
uses: actions/checkout@v4
with:
fetch-depth: 1
- name: Install buf
uses: bufbuild/buf-setup-action@v1
fetch-depth: 2
- name: Buf CI
uses: bufbuild/buf-action@v1
with:
github_token: ${{ github.token }}
- name: Buf format
run: buf format -d --exit-code
- name: Buf lint
uses: bufbuild/buf-lint-action@v1
- name: Buf generate
run: |
mkdir -p .tmp/bin
cp $(which buf) .tmp/bin/buf
make checkgenerate
format: true
lint: true
breaking: true
push: false
archive: false
- name: Check Generate
run: make checkgenerate
13 changes: 7 additions & 6 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go-version: [ 1.20.x, 1.21.x, 1.22.x ]
go-version:
- 1.20.x
rodaine marked this conversation as resolved.
Show resolved Hide resolved
- 1.21.x
- 1.22.x
- 1.23.x
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -33,8 +37,5 @@ jobs:
- name: Lint
# Often, lint guidelines depend on the Go version. To prevent
# conflicting guidance, run only on the most recent supported version.
if: matrix.go-version == '1.22.x'
run: make lint
- name: Check Generate
if: matrix.go-version == '1.22.x'
run: make checkgenerate
rodaine marked this conversation as resolved.
Show resolved Hide resolved
if: matrix.go-version == '1.23.x'
run: make lint-go
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ LICENSE_IGNORE := -e internal/testdata/
# Set to use a different compiler. For example, `GO=go1.18rc1 make test`.
GO ?= go
ARGS ?= --strict --strict_message --strict_error
GOLANGCI_LINT_VERSION ?= v1.59.1
GOLANGCI_LINT_VERSION ?= v1.60.1
# Set to use a different version of protovalidate-conformance.
# Should be kept in sync with the version referenced in proto/buf.lock and
# 'buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go' in go.mod.
Expand Down
Loading