Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Incorrect booking 500s #18784

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Incorrect booking 500s #18784

wants to merge 1 commit into from
+25 −12

Conversation

keithwillcode
Copy link
Contributor

What does this PR do?

These rate limit exceptions were causing 500s to be returned from the server, which is incorrect. They need to return as 429 directly from the origin server.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@keithwillcode keithwillcode self-assigned this Jan 21, 2025
@keithwillcode keithwillcode added this to the v5.0 milestone Jan 21, 2025
@graphite-app graphite-app bot requested a review from a team January 21, 2025 15:11
@keithwillcode keithwillcode added core area: core, team members only foundation labels Jan 21, 2025
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working labels Jan 21, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 21, 2025

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (01/21/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode marked this pull request as draft January 21, 2025 15:20
@zomars zomars mentioned this pull request Jan 22, 2025
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@keithwillcode keithwillcode

Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working core area: core, team members only foundation
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@keithwillcode