Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighttpd: Add socket support and documentation #931

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sbrunner
Copy link
Member

No description provided.

@sbrunner sbrunner force-pushed the lighttpd branch 2 times, most recently from 5055b00 to 44247d5 Compare January 19, 2025 16:44
@sbrunner
Copy link
Member Author

Many thanks @gstrauss :-)

@sbrunner sbrunner requested a review from danduk82 January 20, 2025 10:03
),
)
)
include_shell "./gen-server"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My prior comment is not resolved. Your startup script /usr/local/bin/start-server does not cd /etc/lighttpd, so this is another case of "you have not tested well".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it again, and it is working locally and in the container :-)
It looks like that lighttpd changed the working directory!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that you're testing lighttpd? It appears that you're testing Apache.
SERVER=apache in the Dockerfile.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbrunner sbrunner marked this pull request as ready for review January 20, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants