fix(image-builder): Add kaniko api server env vars config to pred job image builder #622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously in https://github.com/caraml-dev/merlin/pull/621/files, a change has been made to allow the API server to propagate environment variables within its environment to the build environment of all Kaniko jobs that it spins up. However, this only happens for all Merlin web service image building jobs (and not batch prediction image building jobs) because the config
KanikoAPIServerEnvVars
is not passed as a field of the batch prediction image building job config.This PR addresses this bug by simply adding the
KanikoAPIServerEnvVars
field as one of the new fields to create when the batch prediction image building job config gets initiliased.Modifications
api/cmd/api/setup.go
- AddKanikoAPIServerEnvVars
to batching prediction image building job configTests
None
Checklist
Release Notes