DB Schema migration tool #9
Conversation
|
Shouldn't this tool go to a separate repository? After all, it's a standalone tool, not a "plugin". I'd push it into https://gitlab.cern.ch/cernbox/ops/cbox-scripts/ (not a public repo, but a priori nobody out there has ever used Reva with the DB). |
jessegeens
force-pushed
the
feat/db-schema-migrator
branch
29 times, most recently
from
9a7baaf to
8023e8c
Compare
jessegeens
force-pushed
the
feat/db-schema-migrator
branch
8 times, most recently
from
c78d0be to
c738e9d
Compare
jessegeens
force-pushed
the
feat/db-schema-migrator
branch
from
c738e9d to
67e9d7b
Compare
Let's do this after the migration is complete :) |
|
OK, the understanding here is that the migration tool depends on other internal packages in this repo, so it's easier to compile it here in place. After the migration, we will move the two files in a separate repo along with basic instructions on how to compile them. |
|
|
||
| func migrateShareStatuses(ctx context.Context, migrator Migrator) { | ||
| // Check how many shares are to be migrated | ||
| count, err := getCount(migrator, "oc_share") |
There was a problem hiding this comment.
| count, err := getCount(migrator, "oc_share") | |
| count, err := getCount(migrator, "oc_share_status") |
| }, | ||
| User: s.recipient, | ||
| Hidden: s.state == -1, // Hidden if REJECTED | ||
| Synced: true, // for now, we always sync? or not? TODO |
There was a problem hiding this comment.
I would say yes.. Had the same question in the other PR..
| // ShareTypeFederatedCloudShare = 6 | ||
| // ShareTypeSpaceMembership = 7 | ||
| if s.ShareType == 0 || s.ShareType == 1 { | ||
| return &ShareOrLink{ |
There was a problem hiding this comment.
Not asking to change, but wouldn't it there be a way to just return "interface" and then use reflection to check the type of object when doing the "create if"?
Depends on #8