-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promise based filter function #89
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 83.47% 84.29% +0.81%
==========================================
Files 5 5
Lines 115 121 +6
Branches 38 40 +2
==========================================
+ Hits 96 102 +6
Misses 7 7
Partials 12 12
Continue to review full report at Codecov.
|
okay, looks good, but the reason for this ? also, you should add a test that covers the promise based filtering, so that the coverage doesn't go down. |
Will take care about this tomorrow. Why? To be able to use something like this |
I could imaging using promises for a |
@championswimmer i added a test. Had to use a timeout because to wait for storage change. |
Any chance we could get this merged? |
Needed this functionality really bad. So here it is.