fix: use env to generate config.Environ() #414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will use the
env
'sOnSet
to record the variable names and values in order to generateconfig.Environ()
results.The side effect I can think of: if the config values are changed outside of the env after loading, they'll not be applied.
I see we have yaml tags too... if we load the settings from yaml, and then from env (which seems to be the case), it should be fine.
Also changed a bunch of tests to use
t.Setenv
instead ofos.Setenv
/os.Unsetenv