Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused config files #88

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Jan 21, 2025

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Removing unused configs that are already a part of the examples folder. Also didn't notice them being used anywhere else.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

CI tests in this PR should go through.

Signed-off-by: Vishnu Challa <[email protected]>
@jtaleric
Copy link
Member

What do you mean by unused? I use the trt-payload-cluster-density

@vishnuchalla
Copy link
Collaborator Author

What do you mean by unused? I use the trt-payload-cluster-density

We have the same config file in examples folder as well. And the same applies to other files in configs folder. Can we just keep all the configurations in one folder?

@jtaleric
Copy link
Member

What do you mean by unused? I use the trt-payload-cluster-density

We have the same config file in examples folder as well. And the same applies to other files in configs folder. Can we just keep all the configurations in one folder?

ah, good point. yes.

Copy link
Collaborator

@paigerube14 paigerube14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jtaleric jtaleric merged commit 2e217b1 into cloud-bulldozer:main Jan 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants