Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes #23

Merged
merged 8 commits into from
Mar 31, 2024
Merged

Routes #23

merged 8 commits into from
Mar 31, 2024

Conversation

Froggy618157725
Copy link
Collaborator

@Froggy618157725 Froggy618157725 commented Mar 4, 2024

Add Routes Utility Object

Routes can be exported and shared manually via the console/inspector. They can be traversed, which will automatically transition to the map each zone was set in. Traversing a route will also switch to the correct activity for it, although this will currently delete the route. That will be fixed in a later version.

Copy link
Owner

@cohaereo cohaereo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary nitpicks

src/ecs/components.rs Outdated Show resolved Hide resolved
src/ecs/components.rs Outdated Show resolved Hide resolved
@Froggy618157725 Froggy618157725 force-pushed the routes branch 3 times, most recently from af69327 to 63ec2ea Compare March 23, 2024 10:51
Set the fraction of the line that will be visible. 1.0 would be a solid line.
Existing dash would be 0.5
0.5 matches old behavior
Actions can be started, tested for completion, and may abort. if aborted, the queue is cleared.
We'll need this for routes, but we can't access it since there's already a mutable reference elsewhere. Instead we pass the value we need along.
Routes show a path through a set of maps. They can be exported to
the clipboad, and reimported via the console.
@Froggy618157725 Froggy618157725 marked this pull request as ready for review March 30, 2024 09:17
src/overlays/activity_select.rs Outdated Show resolved Hide resolved
src/overlays/activity_select.rs Outdated Show resolved Hide resolved
src/overlays/activity_select.rs Outdated Show resolved Hide resolved
src/map.rs Outdated Show resolved Hide resolved
src/ecs/components.rs Outdated Show resolved Hide resolved
src/action.rs Outdated Show resolved Hide resolved
Made route traversal speed based, with an adjustable modifier. Is not currently based on camera speed, but could be.
Angle changing is a bit off. Couldn't figure out the issue, so went with something that looked less weird. I added a TODO there
Fixed a route bug that would add an empty node if the route has an associated activity hash.
Route nodes are now affected by scaling.
@cohaereo cohaereo merged commit 2b467b9 into cohaereo:lightfall Mar 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants