-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routes #23
Merged
Merged
Routes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cohaereo
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary nitpicks
Froggy618157725
force-pushed
the
routes
branch
3 times, most recently
from
March 23, 2024 10:51
af69327
to
63ec2ea
Compare
Set the fraction of the line that will be visible. 1.0 would be a solid line. Existing dash would be 0.5
0.5 matches old behavior
Actions can be started, tested for completion, and may abort. if aborted, the queue is cleared.
We'll need this for routes, but we can't access it since there's already a mutable reference elsewhere. Instead we pass the value we need along.
Routes show a path through a set of maps. They can be exported to the clipboad, and reimported via the console.
cohaereo
requested changes
Mar 30, 2024
Made route traversal speed based, with an adjustable modifier. Is not currently based on camera speed, but could be. Angle changing is a bit off. Couldn't figure out the issue, so went with something that looked less weird. I added a TODO there Fixed a route bug that would add an empty node if the route has an associated activity hash. Route nodes are now affected by scaling.
cohaereo
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Routes Utility Object
Routes can be exported and shared manually via the console/inspector. They can be traversed, which will automatically transition to the map each zone was set in. Traversing a route will also switch to the correct activity for it, although this will currently delete the route. That will be fixed in a later version.