-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ts): morpho vault deposit & withdraw actions #114
Merged
stat
merged 33 commits into
master
from
christopher.gerber/feat/nodejs-morpho-actions-vault-deposit-and-withdrawl
Jan 22, 2025
Merged
feat(ts): morpho vault deposit & withdraw actions #114
stat
merged 33 commits into
master
from
christopher.gerber/feat/nodejs-morpho-actions-vault-deposit-and-withdrawl
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
Co-authored-by: John Peterson <[email protected]>
Co-authored-by: John Peterson <[email protected]>
Co-authored-by: John Peterson <[email protected]>
Co-authored-by: John Peterson <[email protected]>
Co-authored-by: John Peterson <[email protected]>
stat
changed the title
feat: nodejs - morpho vault deposit & withdraw actions
feat(typescript): morpho vault deposit & withdraw actions
Jan 16, 2025
stat
changed the title
feat(typescript): morpho vault deposit & withdraw actions
feat(ts): morpho vault deposit & withdraw actions
Jan 16, 2025
stat
force-pushed
the
christopher.gerber/feat/nodejs-morpho-actions-vault-deposit-and-withdrawl
branch
from
January 17, 2025 22:58
9f9497e
to
fe87285
Compare
Co-authored-by: John Peterson <[email protected]>
Co-authored-by: John Peterson <[email protected]>
Co-authored-by: John Peterson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review to ensure previous comments are resolved prior to review. Also please ensure that language conventions are translated when copying from python implementations and vice versa
cdp-agentkit-core/typescript/src/actions/cdp/defi/morpho/deposit.ts
Outdated
Show resolved
Hide resolved
cdp-agentkit-core/typescript/src/actions/cdp/defi/morpho/deposit.ts
Outdated
Show resolved
Hide resolved
…it.ts Co-authored-by: John Peterson <[email protected]>
Co-authored-by: John Peterson <[email protected]>
cdp-agentkit-core/typescript/src/tests/defi_morpho_deposit_test.ts
Outdated
Show resolved
Hide resolved
…t.ts Co-authored-by: John Peterson <[email protected]>
John-peterson-coinbase
approved these changes
Jan 22, 2025
stat
deleted the
christopher.gerber/feat/nodejs-morpho-actions-vault-deposit-and-withdrawl
branch
January 22, 2025 23:13
stat
added a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
morpho_deposit
to deposit to Morpho Vault on Basemorpho_withdraw
to withdraw from a Morpho Vault on BaseHow was this tested?
[x] chatbot with packages redirected to local
Deposit
Withdraw
Qualified Impact