Implemented canLogIn check for authenticate method. FIXES #52
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests to check `canLogIn` calls.
| * Extension to test "canLogin" | ||
| */ | ||
| class TestCanLoginExtension extends DataExtension |
There was a problem hiding this comment.
Would be cleaner to have this as a different file and rename the class to follow the same pattern as the other ones like RESTfulAPI_CanLogInExtension_Test.php
There was a problem hiding this comment.
It's only being used for this test-case.. so moving it to an external file seems counter-intuitive as it makes understanding of the test more difficult. As for naming, feel free to rename it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
loginmethod itself already checkscanLogIn, deeply covered inMemberAuthenticator::authenticate, so onlyauthenticatehad to be fixed.Added a test to
RESTfulAPI_TokenAuthenticator_Testthat checks both authentication methods (login&authenticate) forcanLogIn.