Replace raw files popup with a table #277 #487

RossGGG · 2024-06-02T23:21:54Z

This pull request fixes #277 .

Added material-ui x DataGrid and styling dependencies to package.json
New Menu item in 'Files' popup to view 'Route Files'
New FilesTable modal that utilizes mui DataGrid component to display a table with links for all segment(s) uploaded files.

* Added material-ui x DataGrid and styling dependencies to package.json * New Menu item in 'Files' popup to view 'Route Files' * New FilesTable modal that utilizes mui DataGrid component to display a table with links for all segment(s) uploaded files.

adeebshihadeh · 2024-06-03T04:23:31Z

Looks like this isn't exposed in the UI yet?

macdoos · 2024-06-03T06:09:37Z

Sup, I've been following this PR and managed to get the table showing in the modal with a couple of changes to the FileTable.jsx. Would you like me to push a commit?

RossGGG · 2024-06-03T21:04:36Z

Looks like this isn't exposed in the UI yet?

Sorry about that. It looks like those changes got wiped when I did a rebase. I re-committed the missing changes to add the menu item.
@macdoos I might have pushed similar changes just now. Let me know.

RossGGG · 2024-06-03T21:06:00Z

And here is the table opened up with the demo data.

adeebshihadeh · 2024-06-03T21:11:13Z

Looks pretty good, but didn't work for me. Here's the console log.
localhost-1717449008310.log

RossGGG · 2024-06-03T21:15:19Z

Looks pretty good, but didn't work for me. Here's the console log. localhost-1717449008310.log

Try rebuilding your node_modules repository with a fresh pnpm install. I had to add the dependencies for x-data-grid to package.json and that extra step was necessary for me to get it to load. If that's not it, were you trying it with the demo data? I don't have any comma hardware, so perhaps there a case that needs to be handled with the live data...

macdoos · 2024-06-04T00:39:42Z

@RossGGG I don't have permission to push to this PR. Regarding the data, if you want to populate the table, you can use the app in demo mode.

RossGGG · 2024-06-04T22:20:23Z

@macdoos Yeah I did that, and it works fine with the demo data. Not sure why the test suite is showing failed now. It works locally.

macdoos · 2024-06-05T03:43:45Z

@RossGGG Have you tried running the tests locally? Also, could you please give me write access to this PR so I can try?

RossGGG · 2024-06-05T03:48:52Z

@RossGGG Have you tried running the tests locally? Also, could you please give me write access to this PR so I can try?

I ran the tests locally on the live repo and they went fine every time. When I do a build and run the tests, it gets more inconsistent but usually works. When I serve the build and go through the steps manually they always produce the expected results, and the error messages the automated tests give when they have failed have been too generic to point to any underlying issue.

I think you'll need access to my fork to update the PR. I just sent you a collaboration invite.

RossGGG · 2024-06-05T18:44:55Z

@macdoos Seems to work for me. It was working before your latest commit too, but good to know it works for multiple people now.

adeebshihadeh

There's a bug where the second click on the "Files" button opens the new table instead of the intermediate popup.

adeebshihadeh · 2024-06-05T19:09:24Z

package.json

+    "@mui/x-data-grid": "^7.6.1",
+    "@emotion/styled": "^11.11.5",
+    "@emotion/react": "^11.4.0",


what are these for? a table shouldn't really require any new dependencies

I used the x-data-grid react component because the Table react component in the legacy version of material-ui being used for this project does not support virtualized paging and I assumed live datasets could contain a larger number of segments and files than the demo dataset provided. If this assumption was incorrect, I can update it to use the Table react component instead.

src/__puppeteer__/drive.test.js

This reverts commit ea20c5a. Revert "Increasing drive.test timeout to 80000ms" This reverts commit 5cf4d9d. Revert "Increase drive.test timeout to 100000ms" This reverts commit 3b47eaa.

RossGGG · 2024-06-06T00:04:11Z

There's a bug where the second click on the "Files" button opens the new table instead of the intermediate popup.
@adeebshihadeh
I have reverted the commit that introduced this bug. It should behave as expected again.

adeebshihadeh · 2024-06-06T02:23:01Z

Can you rebase to get the new preview deployment? Then you can share the link on our Discord and have some people stress test it.

RossGGG · 2024-06-06T02:34:13Z

Can you rebase to get the new preview deployment? Then you can share the link on our Discord and have some people stress test it.

Yeah that sounds good. I will go do that now.

* Added material-ui x DataGrid and styling dependencies to package.json * New Menu item in 'Files' popup to view 'Route Files' * New FilesTable modal that utilizes mui DataGrid component to display a table with links for all segment(s) uploaded files.

This reverts commit ea20c5a. Revert "Increasing drive.test timeout to 80000ms" This reverts commit 5cf4d9d. Revert "Increase drive.test timeout to 100000ms" This reverts commit 3b47eaa.

* Fix table for segments that do not have available uploads for certain file types. * Fix style for header filler cells if columns do not span the full width of the table.

…table # Conflicts: # src/components/Files/FileTable.jsx

RossGGG · 2024-06-06T03:51:55Z

Can you rebase to get the new preview deployment? Then you can share the link on our Discord and have some people stress test it.

The preview deployment is failing due to a missing secret (apiKey) for CloudFlare.

adeebshihadeh · 2024-06-06T06:00:27Z

Should be fixed now if you rebase.

github-actions · 2024-06-06T06:28:11Z

Welcome to connect! Make sure to:

read the contributing guidelines
mark your PR as a draft until it's ready to review
post the preview on Discord; feedback from users will speedup the PR review

deployed preview: https://487.connect-d5y.pages.dev

RossGGG · 2024-06-06T06:34:33Z

Should be fixed now if you rebase.

It seems to be building now, but the built preview does not reflect/include the changes from the PR.

adeebshihadeh · 2024-06-06T20:43:13Z

Should be fixed now if you rebase.

It seems to be building now, but the built preview does not reflect/include the changes from the PR.

Should be fixed now if you rebase.

RossGGG · 2024-06-06T21:00:35Z

@adeebshihadeh It looks like the test is failing now, I think because there is no demo data in the default date range when the UI loads now. The preview deployment does seem to have updated with the PR changes, so I will post it on the Discord.

* Disabled the column header menus on the fild download columns since they caused formatting issues when they appear, and they don't have much practical use on those columns * Disabled cell focus box appearing on headers.

adeebshihadeh · 2024-06-25T20:40:23Z

I'm closing out this bounty, since we're shifting our focus over to new-connect.

The work is done though, so you're good to collect the bounty. Instructions here: https://github.com/commaai/openpilot/blob/master/docs/BOUNTIES.md

RossGGG added 2 commits June 2, 2024 16:20

Cleanup unused variables

26a4c0e

RossGGG marked this pull request as ready for review June 2, 2024 23:42

RossGGG added 2 commits June 2, 2024 22:34

Added Route Files menu item and button to open Route Files modal

57488bf

Updated package.json with material-ui x DataGrid dependencies.

7baaae3

RossGGG added 2 commits June 2, 2024 23:52

Fix typo

2f39bd0

Increasing drive.test timeout to 80000ms

5cf4d9d

RossGGG added 2 commits June 3, 2024 14:20

Fix visible row borders.

3638c3c

Increase drive.test timeout to 100000ms

3b47eaa

Show table in modal

ea20c5a

macdoos force-pushed the raw_files_table branch from dbb373f to ea20c5a Compare June 5, 2024 04:18

adeebshihadeh requested changes Jun 5, 2024

View reviewed changes

Revert "Show table in modal"

47d90bd

This reverts commit ea20c5a. Revert "Increasing drive.test timeout to 80000ms" This reverts commit 5cf4d9d. Revert "Increase drive.test timeout to 100000ms" This reverts commit 3b47eaa.

RossGGG added 3 commits June 5, 2024 19:52

Cleanup unused variables

50922b8

Added Route Files menu item and button to open Route Files modal

6eb2e82

RossGGG and others added 9 commits June 5, 2024 19:52

Updated package.json with material-ui x DataGrid dependencies.

3817206

Fix typo

289dd4e

Increasing drive.test timeout to 80000ms

66bbd61

Fix visible row borders.

4dc0cd4

Increase drive.test timeout to 100000ms

55722e2

Show table in modal

0d61b89

Revert "Show table in modal"

0c5f8c4

This reverts commit ea20c5a. Revert "Increasing drive.test timeout to 80000ms" This reverts commit 5cf4d9d. Revert "Increase drive.test timeout to 100000ms" This reverts commit 3b47eaa.

Empty Table Cells handling

9bcc079

* Fix table for segments that do not have available uploads for certain file types. * Fix style for header filler cells if columns do not span the full width of the table.

Merge remote-tracking branch 'origin/raw_files_table' into raw_files_…

9733c7b

…table # Conflicts: # src/components/Files/FileTable.jsx

Merge remote-tracking branch 'source/master' into raw_files_table

9ce3354

Merge remote-tracking branch 'source/master' into raw_files_table

b4408bc

RossGGG added 2 commits June 6, 2024 16:21

File Table Column Header Menus

f3aec8d

* Disabled the column header menus on the fild download columns since they caused formatting issues when they appear, and they don't have much practical use on those columns * Disabled cell focus box appearing on headers.

Merge remote-tracking branch 'source/master' into raw_files_table

1f4a14e

macdoos mentioned this pull request Jun 23, 2024

Replace files popup with a table #531

Closed

adeebshihadeh closed this Jun 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace raw files popup with a table #277 #487

Replace raw files popup with a table #277 #487

RossGGG commented Jun 2, 2024 •

edited

Loading

adeebshihadeh commented Jun 3, 2024

macdoos commented Jun 3, 2024

RossGGG commented Jun 3, 2024

RossGGG commented Jun 3, 2024

adeebshihadeh commented Jun 3, 2024

RossGGG commented Jun 3, 2024 •

edited

Loading

macdoos commented Jun 4, 2024

RossGGG commented Jun 4, 2024

macdoos commented Jun 5, 2024

RossGGG commented Jun 5, 2024 •

edited

Loading

RossGGG commented Jun 5, 2024

adeebshihadeh left a comment

adeebshihadeh Jun 5, 2024

RossGGG Jun 5, 2024

RossGGG commented Jun 6, 2024

adeebshihadeh commented Jun 6, 2024

RossGGG commented Jun 6, 2024

RossGGG commented Jun 6, 2024

adeebshihadeh commented Jun 6, 2024

github-actions bot commented Jun 6, 2024 •

edited

Loading

RossGGG commented Jun 6, 2024

adeebshihadeh commented Jun 6, 2024

RossGGG commented Jun 6, 2024

adeebshihadeh commented Jun 25, 2024

Replace raw files popup with a table #277 #487

Replace raw files popup with a table #277 #487

Conversation

RossGGG commented Jun 2, 2024 • edited Loading

adeebshihadeh commented Jun 3, 2024

macdoos commented Jun 3, 2024

RossGGG commented Jun 3, 2024

RossGGG commented Jun 3, 2024

adeebshihadeh commented Jun 3, 2024

RossGGG commented Jun 3, 2024 • edited Loading

macdoos commented Jun 4, 2024

RossGGG commented Jun 4, 2024

macdoos commented Jun 5, 2024

RossGGG commented Jun 5, 2024 • edited Loading

RossGGG commented Jun 5, 2024

adeebshihadeh left a comment

Choose a reason for hiding this comment

adeebshihadeh Jun 5, 2024

Choose a reason for hiding this comment

RossGGG Jun 5, 2024

Choose a reason for hiding this comment

RossGGG commented Jun 6, 2024

adeebshihadeh commented Jun 6, 2024

RossGGG commented Jun 6, 2024

RossGGG commented Jun 6, 2024

adeebshihadeh commented Jun 6, 2024

github-actions bot commented Jun 6, 2024 • edited Loading

RossGGG commented Jun 6, 2024

adeebshihadeh commented Jun 6, 2024

RossGGG commented Jun 6, 2024

adeebshihadeh commented Jun 25, 2024

RossGGG commented Jun 2, 2024 •

edited

Loading

RossGGG commented Jun 3, 2024 •

edited

Loading

RossGGG commented Jun 5, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading