Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort routes based on create_time #69

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

vishalkrishnads
Copy link

@vishalkrishnads vishalkrishnads commented Jul 12, 2024

Fixes #60. Got rid of the pages[] array and implemented a more straightforward list rendering logic. The onLoadMore() method for infinite scrolling has been preserved. The dates/times on all the route cards have been removed.

Copy link

github-actions bot commented Jul 12, 2024

deployed preview: https://69.connect-d5y.pages.dev

Welcome to new-connect! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

@mfeinLearn
Copy link

Are the conflicts resolved yet?

@vishalkrishnads
Copy link
Author

The conflicts have been resolved. However, I'm seeing that /src/pages/dashboard/activities/PairActivity.tsx has a lot of unsafe call, returns & assignments. I've disabled everything for now since that is out of the scope of this PR. Worth checking later.

@mfeinLearn

This comment was marked as spam.

@vishalkrishnads
Copy link
Author

😂 seriously?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle routes with no time
2 participants