fix(core): update environment variable generation logic in Applicatio…

…nDeploymentJob to handle different build packs
coollabsio · Jan 22, 2025 · c3c032e · c3c032e
1 parent bae8b9a
commit c3c032e
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/app/Jobs/ApplicationDeploymentJob.php b/app/Jobs/ApplicationDeploymentJob.php
@@ -2288,8 +2288,12 @@ private function start_by_compose_file()
 
     private function generate_build_env_variables()
     {
-        $variables = collect($this->nixpacks_plan_json->get('variables'));
-        $variables->put('SOURCE_COMMIT', $this->commit);
+        if ($this->application->build_pack === 'nixpacks') {
+            $variables = collect($this->nixpacks_plan_json->get('variables'));
+        } else {
+            $this->generate_env_variables();
+            $variables = collect([])->merge($this->env_args);
+        }
 
         $this->build_args = $variables->map(function ($value, $key) {
             $value = escapeshellarg($value);