Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view holder wrapper inaccessible #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Joe3112
Copy link

@Joe3112 Joe3112 commented Mar 8, 2021

Hey there, just a small fix when using the library in a Kotlin project, Android Studio shows a nasty warning that ViewHolderWrapper is inaccessible. Looks like an issue with Java and Kotlin interop.

@lizapopova
Copy link
Collaborator

Hi @Joe3112, thanks for using the library!
Could you please explain in which circumstances do you see the warning?
ViewHolderWrapper is an internal class that was not supposed to be used/instantiated by the library users. You are suggesting to make it publicly available instead of being package-private. Could you use RecyclerView.Adapter<RecyclerView.ViewHolder> instead of RecyclerView.Adapter<ViewHolderWrapper> in your case?
Please share some context to help me understand what is the best resolution for this situation.
Thanks!

@Joe3112
Copy link
Author

Joe3112 commented Mar 24, 2021

Hi, Sorry for the late reply... I'm not using ViewHolderWrapper directly, but the issue was that Kotlin was unable to access it.

@Jung0x12
Copy link

like this
截圖 2021-08-19 下午3 47 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants