fix(credentials): ensure deletion occurs within transaction context

[andrewazores]

Welcome to Cryostat! 👋

Before contributing, make sure you have:

• Read the contributing guidelines
• Linked a relevant issue which this PR resolves
• Linked any other relevant issues, PR's, or documentation, if any
• Resolved all conflicts, if any
• Rebased your branch PR on top of the latest upstream main branch
• Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
• Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

---

Fixes: #753

Description of the change:

Ensures transaction context is active when processing credential deletions in particular situations.

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

1. Check out PR
2. Apply this patch:

diff --git a/src/main/java/io/cryostat/discovery/Discovery.java b/src/main/java/io/cryostat/discovery/Discovery.java
index 508dbd55..0279cc46 100644
--- a/src/main/java/io/cryostat/discovery/Discovery.java
+++ b/src/main/java/io/cryostat/discovery/Discovery.java
@@ -215,6 +215,9 @@ public class Discovery {
                             remoteURI));
         }
 
+        if (true) {
+            throw new BadRequestException();
+        }
         if (agentTlsRequired && !callbackUri.getScheme().equals("https")) {
             throw new BadRequestException(
                     String.format(

3. Build PR
4. ./smoketest.bash -O -t quarkus-cryostat-agent
5. Because of the patch above, the Agent instance should fail to register itself with Cryostat. Check Cryostat's logs when this happens. Before this PR, exceptions like in [Bug] Credential deletion happens outside of a transaction context #753 will be seen. With this PR the logs should be clean when the Agent instance fails to register and tries to clean up its own credentials.
6. Alternatively, simply open the web UI and go to Security, then define a credential. Then try to delete it, and check the Cryostat logs immediately after. The same kind of stack trace should appear if this PR is not applied. Requires fix(storedcredentials): define target match array to avoid undefined reference error cryostat-web#1513

[andrewazores]

/build_test

[github-actions]

Workflow started at 12/23/2024, 11:53:17 AM. View Actions Run.

[github-actions]

No OpenAPI schema changes detected.

[github-actions]

No GraphQL schema changes detected.

[github-actions]

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/12470186351

[Josh-Matsuoka]

Looks good to me other than the log level question I asked above, is it intended to keep the quarkus logging at ALL?

[andrewazores]

I'm not seeing any question above, but if you mean the quarkus.log.level=ALL in application-dev.properties, that's intentional since it is useful during development (the only time these property values are loaded) to see all warnings emitted.