-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor IAM id access #8969
Merged
Merged
Refactor IAM id access #8969
+126
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiltsov-max
requested review from
SpecLad
and removed request for
Marishka17
January 20, 2025 17:08
zhiltsov-max
force-pushed
the
zm/optimize-iam-data-access
branch
from
January 20, 2025 17:11
677cb5d
to
c382cc4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8969 +/- ##
===========================================
- Coverage 73.84% 73.84% -0.01%
===========================================
Files 417 417
Lines 44591 44602 +11
Branches 4031 4031
===========================================
+ Hits 32927 32935 +8
- Misses 11664 11667 +3
|
SpecLad
reviewed
Jan 21, 2025
SpecLad
reviewed
Jan 21, 2025
SpecLad
approved these changes
Jan 21, 2025
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing object id access pattern for foreign keys produces unnecessary dependencies on the whole foreign object. It can be optimized to using just the object id, which is stored in the same db row in most cases (except m2m fields). This change doesn't immediately lead to optimized DB requests, but it opens optimization opportunities in the future.
obj
field type annotations forPermission
typesMotivation and context
How has this been tested?
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.