Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked headlessCreateUser command in Cypress #8977

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jan 21, 2025

Motivation and context

Now the command does not set any cookies to the browser automatically.
So, we do not have to use clearCookies() each time after calling cy.headlessCreateUser()

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev requested a review from azhavoro as a code owner January 21, 2025 18:47
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@bsekachev bsekachev merged commit c2bfb21 into develop Jan 21, 2025
30 of 32 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.83%. Comparing base (4c5e522) to head (a1c9e55).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8977   +/-   ##
========================================
  Coverage    73.82%   73.83%           
========================================
  Files          417      417           
  Lines        44591    44591           
  Branches      4031     4031           
========================================
+ Hits         32921    32925    +4     
+ Misses       11670    11666    -4     
Components Coverage Δ
cvat-ui 78.27% <ø> (+0.01%) ⬆️
cvat-server 70.06% <ø> (ø)

@bsekachev bsekachev deleted the bs/reworked_command branch January 22, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants