-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically configure xhprof for xhgui, remove configuration requirements, fixes #33, fixes #30 #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it using a custom PHP project, and with simple Laravel, it worked for me.
And I noticed a small problem with the working_dir
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
19187d3
to
e7ef8fe
Compare
Rebased. |
Great work!
Tested on:
|
The Issue
How This PR Solves The Issue
Manual Testing Instructions
Install with
Try it out in several environments.
The new rendered readme is at https://github.com/ddev/ddev-xhgui/blob/196d4a9de5ea4e42d0b8ea8d337cd48cb572e9d2/README.md
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes