Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error codes for generic errors #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

swehner
Copy link

@swehner swehner commented Jun 4, 2013

This simply adds the generic errors defined in the beanstalk protocol and treats them in the client library so it'll return different error codes if one of these errors is encountered.
I think it would make sense to make these error codes available in the c++ client as well, although this would need major changes in the API, as the function only return bool now.

@deepfryed
Copy link
Owner

Neat!

As for C++, we can have the last client error code stored in the Client instance. You don't need to change the return from bool, but set the code and then access it from another public api. How does that sound ?

@swehner
Copy link
Author

swehner commented Jun 4, 2013

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants