Skip to content

Commit

Permalink
Merge pull request #58 from dell/use-go-base-image
Browse files Browse the repository at this point in the history
Use go base image
  • Loading branch information
adarsh-dell authored Feb 20, 2024
2 parents e072b84 + a528a65 commit 606b8b4
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/linters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ jobs:
name: golangci-lint
runs-on: ubuntu-latest
steps:
- uses: actions/setup-go@v4
- uses: actions/setup-go@v5
with:
go-version: "1.20"
go-version: "1.22"
cache: false
- name: Checkout the code
uses: actions/[email protected]
Expand Down
3 changes: 2 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@
#

ARG BASEIMAGE
ARG GOIMAGE

FROM golang:1.20 as build-env
FROM $GOIMAGE as build-env

WORKDIR /app/cert-csi/
COPY go.mod go.sum ./
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ build:

docker: download-csm-common
$(eval include csm-common.mk)
$(BUILDER) build -t cert-csi:latest --build-arg BASEIMAGE=$(DEFAULT_BASEIMAGE) .
$(BUILDER) build -t cert-csi:latest --build-arg BASEIMAGE=$(DEFAULT_BASEIMAGE) --build-arg GOIMAGE=$(DEFAULT_GOIMAGE) .

# build-statically-linked : used for building a standalone binary with statically linked glibc
# this command should be used when building the binary for distributing it to customer/user
Expand Down

0 comments on commit 606b8b4

Please sign in to comment.